Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including changes in nrcan branch. #1491

Merged
merged 19 commits into from
Apr 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1675086
Modified model_add_daylighting_controls method in a way to set minimu…
srgilani Mar 8, 2023
a41ca39
Modification of model_add_daylighting_controls method and unit test f…
srgilani Mar 9, 2023
e6cb6d8
Modification of daylighting sensor control ECM and its unit test in p…
srgilani Mar 9, 2023
1091913
Added min illuminance level to space_types.json of NECB2011; and NECB…
srgilani Mar 10, 2023
34a0ba5
Modified unit test for daylighting sensor control ecm
srgilani Mar 10, 2023
996f683
Commented in unit test for daylighting sensor control ecm
srgilani Mar 10, 2023
0dbef25
Merge remote-tracking branch 'origin/nrcan' into nrcan_375
srgilani Mar 20, 2023
c80a3e1
Updated bundler version in openstudio-standards.gemspec
srgilani Mar 20, 2023
8d61245
Added min illuminance level to space_types.json of NECB2015
srgilani Mar 21, 2023
24cbdf1
Adding min illuminance level to space_types.json of NECB2017, in prog…
srgilani Mar 21, 2023
d24f49d
Adding min illuminance level to space_types.json of NECB2017
srgilani Mar 22, 2023
66fafc3
Added min illuminance level to space_types.json of NECB2020
srgilani Mar 22, 2023
b6b4217
Added min illuminance level to space_types.json of BTAPPRE1980 and BT…
srgilani Mar 27, 2023
21c1b1b
Set daylighting_type in model_apply_standard method of necb_2011.rb; …
srgilani Mar 27, 2023
cf24c7e
Merge remote-tracking branch 'origin/nrcan' into nrcan_375
srgilani Mar 27, 2023
4b7fff5
Updated expected results files of regression tests for warehouse, ret…
srgilani Mar 28, 2023
3a0d518
Updated expected results files of regression tests for primary and se…
srgilani Mar 29, 2023
3df5aee
Merge pull request #1479 from NREL/nrcan_375: modify daylighting sens…
srgilani Apr 3, 2023
c16ec80
Nrcan 380 (#1489)
phylroy Apr 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

670 changes: 447 additions & 223 deletions lib/openstudio-standards/standards/necb/BTAPPRE1980/data/space_types.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"high_bay_lighting_schedule":
"specialty_lighting_schedule":
"exit_lighting_schedule":
"target_illuminance_setpoint":
"target_illuminance_setpoint": lux
"target_illuminance_setpoint_ref":
"psa_nongeometry_fraction":
"ssa_nongeometry_fraction":
"ventilation_standard":
Expand Down
670 changes: 447 additions & 223 deletions lib/openstudio-standards/standards/necb/NECB2011/data/space_types.json

Large diffs are not rendered by default.

363 changes: 192 additions & 171 deletions lib/openstudio-standards/standards/necb/NECB2011/necb_2011.rb

Large diffs are not rendered by default.

955 changes: 637 additions & 318 deletions lib/openstudio-standards/standards/necb/NECB2015/data/space_types.json

Large diffs are not rendered by default.

955 changes: 637 additions & 318 deletions lib/openstudio-standards/standards/necb/NECB2017/data/space_types.json

Large diffs are not rendered by default.

922 changes: 615 additions & 307 deletions lib/openstudio-standards/standards/necb/NECB2020/data/space_types.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def initialize(input_folder: nil,
model.setSqlFile(sql)

@cost_result = nil
if @options[:enable_costing] == true
if defined?(BTAPCosting)
# Perform costing
costing = BTAPCosting.new
costing.load_database
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading