Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sizing methods #1582

Merged
merged 25 commits into from
Sep 7, 2023
Merged

Remove sizing methods #1582

merged 25 commits into from
Sep 7, 2023

Commits on Aug 25, 2023

  1. remove Siz.AirLoopHVAC.rb

    remove Siz.AirLoopHVAC.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ed8b339 View commit details
    Browse the repository at this point in the history
  2. remove Siz.CoilCoolingWater.rb

    remove Siz.CoilCoolingWater.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5ba9c05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3710796 View commit details
    Browse the repository at this point in the history
  4. remove Siz.HVACComponent.rb

    remove Siz.HVACComponent.rb and associated methods. Only water heaters were using the feature. May consider generalizing if other components need it in the future.
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e38bfc3 View commit details
    Browse the repository at this point in the history
  5. remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb

    remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb and refactor associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0, under coolingFuelTypes, heatingFuelTypes, and appGHeatingFuelTypes
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1f9c89d View commit details
    Browse the repository at this point in the history
  6. remove overloaded prm method plant_loop_total_cooling_capacity

    plant_loop_total_cooling_capacity is overloaded in the prm code and doesn't need to be
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    27e38db View commit details
    Browse the repository at this point in the history
  7. calculate fan power

    calculate fan power from existing field rather than relying on an sql file lookup
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8b99e87 View commit details
    Browse the repository at this point in the history
  8. remove getAutosizedValueFromEquipmentSummary

    remove getAutosizedValueFromEquipmentSummary method from Siz.Model.rb
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    89be23d View commit details
    Browse the repository at this point in the history
  9. remove output_fan_report

    remove output fan report, which was only used for manually checking the older prm method
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e8ec7ec View commit details
    Browse the repository at this point in the history
  10. Delete Siz.Model.rb

    delete Siz.Model.rb and hvac_sizing directory
    mdahlhausen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6d0c652 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    a2b247b View commit details
    Browse the repository at this point in the history
  2. grammar fix

    mdahlhausen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1c54b8e View commit details
    Browse the repository at this point in the history
  3. fix OptionalDouble error

    mdahlhausen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    927274f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    2ad720d View commit details
    Browse the repository at this point in the history
  2. refactor design load to be w not w_per_m2

    The original heatingDesignLoad and coolingDesignLoad method sin openstudio-standards were poorly named. They returned load density in w_per_m2 instead of w. Adjust the code to account for the w return from the new OpenStudio methods.
    mdahlhausen committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f7d9499 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. check for OptionalDouble

    mdahlhausen committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ac51ed0 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. fix .get typo for double

    mdahlhausen committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7d20c94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e79863a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cc75f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. remove extra argument

    mdahlhausen committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3c6b9c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Configuration menu
    Copy the full SHA
    9aa6c6b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7bd20d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c124da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    40e49f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. update test failures

    mdahlhausen committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    97840e9 View commit details
    Browse the repository at this point in the history