Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sizing methods #1582

Merged
merged 25 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ed8b339
remove Siz.AirLoopHVAC.rb
mdahlhausen Aug 25, 2023
5ba9c05
remove Siz.CoilCoolingWater.rb
mdahlhausen Aug 25, 2023
3710796
remove sizing methods in Siz.ThermalZone.rb
mdahlhausen Aug 25, 2023
e38bfc3
remove Siz.HVACComponent.rb
mdahlhausen Aug 25, 2023
1f9c89d
remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb
mdahlhausen Aug 25, 2023
27e38db
remove overloaded prm method plant_loop_total_cooling_capacity
mdahlhausen Aug 25, 2023
8b99e87
calculate fan power
mdahlhausen Aug 25, 2023
89be23d
remove getAutosizedValueFromEquipmentSummary
mdahlhausen Aug 25, 2023
e8ec7ec
remove output_fan_report
mdahlhausen Aug 25, 2023
6d0c652
Delete Siz.Model.rb
mdahlhausen Aug 25, 2023
a2b247b
remove require to Siz.Model
mdahlhausen Aug 28, 2023
1c54b8e
grammar fix
mdahlhausen Aug 28, 2023
927274f
fix OptionalDouble error
mdahlhausen Aug 28, 2023
2ad720d
get value of FuelType Enums
mdahlhausen Aug 29, 2023
f7d9499
refactor design load to be w not w_per_m2
mdahlhausen Aug 29, 2023
ac51ed0
check for OptionalDouble
mdahlhausen Aug 30, 2023
7d20c94
fix .get typo for double
mdahlhausen Aug 31, 2023
e79863a
Update Standards.ThermalZone.rb
mdahlhausen Aug 31, 2023
9cc75f2
update regression and performance results
mdahlhausen Aug 31, 2023
3c6b9c1
remove extra argument
mdahlhausen Sep 1, 2023
9aa6c6b
Merge branch 'master' into remove_sizing_methods
mdahlhausen Sep 2, 2023
a7bd20d
fix app g method call typos
mdahlhausen Sep 2, 2023
4c124da
Update test_performance_expected_dd_results.csv
mdahlhausen Sep 2, 2023
40e49f4
check app G fuel type against array
mdahlhausen Sep 2, 2023
97840e9
update test failures
mdahlhausen Sep 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions data/standards/test_performance_expected_dd_results.csv

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions lib/openstudio-standards.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
module OpenstudioStandards
require 'json' # Used to load standards JSON files

# HVAC sizing
require_relative 'openstudio-standards/hvac_sizing/Siz.Model'

# Weather data
require_relative 'openstudio-standards/weather/Weather.Model'

Expand Down
59 changes: 0 additions & 59 deletions lib/openstudio-standards/hvac_sizing/Siz.AirLoopHVAC.rb

This file was deleted.

13 changes: 0 additions & 13 deletions lib/openstudio-standards/hvac_sizing/Siz.CoilCoolingWater.rb

This file was deleted.

36 changes: 0 additions & 36 deletions lib/openstudio-standards/hvac_sizing/Siz.HVACComponent.rb

This file was deleted.

Loading