Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schedule processing error for Appendix G #1687

Merged
merged 16 commits into from
Feb 19, 2024
Merged

Fix schedule processing error for Appendix G #1687

merged 16 commits into from
Feb 19, 2024

Conversation

weilixu
Copy link
Collaborator

@weilixu weilixu commented Feb 15, 2024

Pull request overview

Test Appendix G merged with master and using faster CI test suite.

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

weilixu and others added 12 commits February 9, 2024 11:04
@weilixu
updates to separate tests and remove problematic test case temporary.
34f21f0
@weilixu
remove compliance check temporarily for CI tests
614af8e
@weilixu
turn run orientation to true in the test
f1c0a5f
@weilixu
Merge branch 'master' of https://github.com/NREL/openstudio-standards …
b9df0c6 
…into AppendxiG_dev_fix_error_processing_schedule

# Conflicts:
#	lib/openstudio-standards/standards/Standards.Model.rb
#	test/90_1_prm/prm_check.rb
#	test/90_1_prm/test_appendix_g_prm.rb
@weilixu
Update space type to handle constant schedule
05a24ff
@weilixu
Add schedule limit type to ruleset schedule simple value adjustment t…
0296c20 
…o prevent simulation errors that the schedule value over the lower or upper boundary.
@weilixu
Add additional comment to explain what the function does.
9f94ce6
@weilixu
Merge branch 'add_value_limit_to_ruleset_simple_adj' of https://githu…
4798f56 
…b.com/NREL/openstudio-standards into AppendxiG_dev_fix_error_processing_schedule
@mdahlhausen
formatting edits
d3f0b6a
@mdahlhausen
Merge pull request #1686 from NREL/add_value_limit_to_ruleset_simple_adj
02096c7 
Add schedule limit type to ruleset schedule simple value adjustment t…
@weilixu
Merge branch 'master' of https://github.com/NREL/openstudio-standards …
f79975a 
…into AppendxiG_dev_fix_error_processing_schedule
@weilixu
Merge branch 'AppendixG_Dev' of https://github.com/NREL/openstudio-st…
b9195f5 
…andards into AppendxiG_dev_fix_error_processing_schedule

# Conflicts:
#	test/90_1_prm/test_appendix_g_prm.rb
@weilixu weilixu added the AppendixG Methods to enable the Appendix G model workflow label Feb 15, 2024
@weilixu
fix CI failure for:
9c25c37 
test_fan_power_credits
test_envelope
@weilixu
Fix CI test failure:
502631c 
test_hvac_psz_split_from_mz
test_pe_userdata_handling
@weilixu
address CI failure:
dc63bfb 
test_hvac_sizing_02
@weilixu
fix a typo
da570ef
@weilixu weilixu marked this pull request as ready for review February 19, 2024 15:18
@weilixu weilixu merged commit f2cbd8b into AppendixG_Dev Feb 19, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen changed the title Appendxi g dev fix error processing schedule Fix schedule processing error for Appendix G Apr 9, 2024
@mdahlhausen mdahlhausen deleted the AppendxiG_dev_fix_error_processing_schedule branch September 3, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weilixu @mdahlhausen