Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default WSHP efficiency if capacity too large #1838

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Default WSHP efficiency if capacity too large #1838

merged 2 commits into from
Oct 25, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Oct 22, 2024 •
edited
Loading

Pull request overview

Default the WSHP equipment size to 134999 if the capacity is too large, otherwise the method will fail to return an efficiency for coil properties. The maximum capacity is not that large, and can be encountered with high zone loads, large zones, or especially zones with zone multipliers. This is only for the COP lookup.

Pull Request Author

  • Method changes or additions
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen
Default WSHP efficiency if capacity too large
cfc3dcb 
Default the equipment size to 134999 if the capacity is too large, otherwise the method will fail to return an efficiency for coil properties. The maximum capacity is not that large, and can be encountered with high zone loads, large zones, or especially zones with zone multipliers.
@mdahlhausen mdahlhausen requested a review from eringold October 22, 2024 21:49
@mdahlhausen
update regression and performance results
c9ebea2 
The data center WSHPs in large offices (bottom and mid) were too large and therefore using default efficiencies. Now they still get assigned a value, equal to the maximum equipment size available.

They are not getting treated as a computer room air conditioner, which is a separate issue and may be addressed in another branch.
@mdahlhausen mdahlhausen merged commit e291963 into master Oct 25, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/wshp_efficiency_capacity_limit branch October 25, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eringold eringold eringold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdahlhausen @eringold