Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default WSHP efficiency if capacity too large #1838

Merged
merged 2 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
240 changes: 114 additions & 126 deletions data/standards/test_performance_expected_dd_results.csv

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ def coil_cooling_water_to_air_heat_pump_standard_minimum_cop(coil_cooling_water_
end
coil_props = model_find_object(standards_data[equipment_type], search_criteria, capacity_btu_per_hr, Date.today)

# Check to make sure properties were found
if coil_props.nil?
# search again without capacity
matching_objects = model_find_objects(standards_data[equipment_type], search_criteria, nil, Date.today)
if !matching_objects.empty? && (equipment_type == 'water_source_heat_pumps') && (capacity_btu_per_hr > 135000)
# Issue warning indicate the coil size is may be too large
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of coil '#{coil_cooling_water_to_air_heat_pump.name}' is #{capacity_btu_per_hr.round} Btu/hr, which is larger than the 135,000 Btu/hr maximum capacity listed in the efficiency standard. This may be because of zone loads, zone size, or because zone equipment sizing in EnergyPlus includes zone multipliers. Will assume a capacity of 134,999 Btu/hr for the efficiency lookup.")
coil_props = model_find_object(standards_data[equipment_type], search_criteria, 134999, Date.today)
end
end

# Check to make sure properties were found
if coil_props.nil?
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
Expand Down Expand Up @@ -119,23 +130,10 @@ def coil_cooling_water_to_air_heat_pump_apply_efficiency_and_curves(coil_cooling
if matching_objects.empty?
# This proves that the search_criteria has issue finding the correct coil prop
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
else
# Issue warning indicate the coil size is may be too large
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of the coil: #{coil_cooling_water_to_air_heat_pump.name} maybe too large to be found in the efficiency standard. The coil capacity is #{capacity_btu_per_hr} Btu/hr.")
return sql_db_vars_map
end
return sql_db_vars_map
end

# @todo Add methods to set coefficients, and add coefficients to data spreadsheet
# using OS defaults for now
# tot_cool_cap_coeff1 = coil_props['tot_cool_cap_coeff1']
# if tot_cool_cap_coeff1
# coil_cooling_water_to_air_heat_pump.setTotalCoolingCapacityCoefficient1(tot_cool_cap_coeff1)
# else
# OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find tot_cool_cap_coeff1, will not be set.")
# successfully_set_all_properties = false
# end

# Preserve the original name
orig_name = coil_cooling_water_to_air_heat_pump.name.to_s

Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

97 changes: 0 additions & 97 deletions test/doe_prototype/test_performance_expected_dd_results.csv

This file was deleted.