Update ReadTheDocs configuration #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to resolve one of the bugs with our test suite and pandas 2.1. The other seems to be a pandas issue pandas-dev/pandas#55794 |
|
Shall we push this through and confine the requirements to pandas<2.1 while we await a fix on the pandas side? |
|
Makes sense to me to go ahead with merging this and track the pandas issue separately! |
|
@cdeline @martin-springer I agree with @kandersolar that we should push this through for now. Would one of you be able to review this? |
|
The failing notebook checks are related to a Datahub error affecting our example data. I'm confident the ntoebooks haven't changed with this one, so pushing it through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes are covered by testsCode changes have been evaluated for compatibility/integration with TrendAnalysisNew functions added to__init__.pyAPI.rst is up to date, along with other sphinx docs pagesExample notebooks are rerun and differences in results scrutinizedReadTheDocs is requiring a change in the configuration file (see this failed build):
This PR makes the necessary configuration updates.