Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(courses): 新增學期選擇功能 #59

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(courses): 新增學期選擇功能 #59

wants to merge 8 commits into from

Conversation

iwtba4188
Copy link
Contributor

@iwtba4188 iwtba4188 commented Dec 23, 2023 •
edited
Loading

Note

  • 我已經有預感這個 PR 和前一個會衝突，到時候 merge 的時候加油：D

TODO

  • 把 query param semester 放到 constant/courses.py 裡面：
semester: schemas.courses.CourseSemester = Query(constant.courses.DEFAULT_SEMESTER, example="11210", description="學期代碼")

改為

# routers/courses.py
semester: schemas.courses.CourseSemester = constant.courses.SEMESTER_QUERY

# constant/courses.py
SEMESTER_QUERY = Query(DEFAULT_SEMESTER, example=DEFAULT_SEMESTER.value, description="學期代碼")

（現在不改是因為 #58 和 #59 的內容有點糾纏在一起，等兩個都 merge 之後再改）

@iwtba4188 iwtba4188 added the enhancement New feature or request label Dec 23, 2023
@iwtba4188 iwtba4188 requested a review from l7wei December 23, 2023 16:47
@l7wei
Copy link
Member

l7wei commented Dec 25, 2023

你先把 main 的 merge 進來

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7wei l7wei Awaiting requested review from l7wei

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwtba4188 @l7wei