Install required packages for multi-stage notebooks using %pip
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
rnyak
reviewed
Apr 19, 2022
examples/Deploying-multi-stage-RecSys/01-Building-Recommender-Systems-with-Merlin.ipynb
Show resolved
Hide resolved
examples/Deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb
Show resolved
Hide resolved
rnyak
reviewed
Apr 21, 2022
examples/Deploying-multi-stage-RecSys/01-Building-Recommender-Systems-with-Merlin.ipynb
Show resolved
Hide resolved
| @@ -61,6 +61,16 @@ | |||
| "### Import required libraries and functions" | |||
There was a problem hiding this comment.
can you pls remove this line? we added this into the first notebook, I assume we did not need it here anymore.
Reply via ReviewNB
There was a problem hiding this comment.
Seems safer to leave it here, just in case? That way you can run the notebooks in separate containers for now, but it'll still work once we shift to a single container.
rnyak
approved these changes
Apr 21, 2022
|
@karlhigley I am approving this. Will create another PR to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a little easier to run the multi-stage example notebooks. One open question I have is if we should update the README in that example's directory (which contains installation instructions that are no longer needed), or remove that README altogether (since there are no additional instructions there beyond what's required for the other examples AFAIK.)