Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install required packages for multi-stage notebooks using %pip #221

Merged
merged 3 commits into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,16 @@
"### Import required libraries and functions"
karlhigley marked this conversation as resolved.
Show resolved Hide resolved
karlhigley marked this conversation as resolved.
Show resolved Hide resolved
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "2cd8cc8d-5cc7-4a9f-91e5-3deec6f1fe74",
"metadata": {},
"outputs": [],
"source": [
"%pip install tensorflow \"feast<0.20\" faiss-gpu"
]
},
{
"cell_type": "code",
"execution_count": 2,
Expand Down Expand Up @@ -568,8 +578,6 @@
}
],
"source": [
"model.set_retrieval_candidates_for_evaluation(train_tt)\n",
"\n",
"model.compile(optimizer='adam', run_eagerly=False)\n",
"model.fit(train_tt, validation_data=valid_tt, batch_size=1024*8, epochs=1)"
]
Expand Down Expand Up @@ -1595,6 +1603,7 @@
"outputs": [],
"source": [
"# install tree\n",
"!apt-get update\n",
"!apt-get install tree"
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@
"### Import required libraries and functions"
karlhigley marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls remove this line? we added this into the first notebook, I assume we did not need it here anymore.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safer to leave it here, just in case? That way you can run the notebooks in separate containers for now, but it'll still work once we shift to a single container.

]
},
{
"cell_type": "code",
"execution_count": null,
"id": "ea3756f8-a115-436a-b5d4-48f0641451b9",
"metadata": {},
"outputs": [],
"source": [
"%pip install tensorflow \"feast<0.20\" faiss-gpu"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down