Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to remove num_rows in read_parquet() #891

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Update unit tests to remove num_rows in read_parquet() #891

merged 2 commits into from
Mar 31, 2023

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Mar 30, 2023

The num_rows parameter has been removed from cudf.read_parquet(). This PR updates the unit tests to remove num_rows.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@edknv edknv self-assigned this Mar 30, 2023
@edknv edknv added chore Infrastructure update ci 23.03 labels Mar 30, 2023
@edknv edknv added this to the Merlin 23.03 milestone Mar 30, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-891

@karlhigley
Copy link
Contributor

The test failure here looks related to a change in Core that moved pynvml_mem_size from merlin.core.utils to merlin.core.compat in order to properly configure multiple GPUs when importing Tensorflow. There's a latent circular import issue between compat and utils that starts to crop up when importing one from the other, so I'm not sure if/how we could maintain backwards compatibility there.

@edknv
Copy link
Contributor Author

edknv commented Mar 31, 2023 •
edited
Loading

@karlhigley It sounds like we have to start using merlin.core.compat instead of nvtabular.utils and just change the notebook?

@edknv
Copy link
Contributor Author

edknv commented Mar 31, 2023

Notebook changed in #892 .

@edknv edknv merged commit 46846ed into NVIDIA-Merlin:main Mar 31, 2023
@edknv edknv deleted the ci/cudf_num_rows branch March 31, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

Assignees

@edknv edknv

Labels
23.03 chore Infrastructure update ci
Projects
None yet
Milestone
Merlin 23.03
Development

Successfully merging this pull request may close these issues.
3 participants
@edknv @karlhigley @oliverholworthy