Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nvtabular.utils with merlin.core.compat in criteo nvtabular n… #892

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Mar 31, 2023

…otebook

There was a change in Core that moved pynvml_mem_size from merlin.core.utils to merlin.core.compat. This PR replaces nvtabular.utils with merlin.core.compat in scaling-criteo/02-ETL-with-NVTabular.ipynb.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-892

@edknv edknv self-assigned this Mar 31, 2023
@edknv edknv added bug Something isn't working 23.03 labels Mar 31, 2023
@edknv edknv added this to the Merlin 23.03 milestone Mar 31, 2023
@edknv edknv requested a review from karlhigley March 31, 2023 18:10
@edknv edknv marked this pull request as ready for review March 31, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.03 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants