Incorporate supported_formats property into NVT ops
#1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a property based on a new enumeration in order to provide a clearer definition of the data formats supported by each op. It doesn't use the existing `supports` property/flags, since `CPU` and `GPU` become confusing in the context of data types that can exist on either host or device (like `TensorTable`s backed by Tensorflow and Torch tensors.) We'll later remove the `supports` property, but keeping it here for now allows us to make this change more incrementally.
oliverholworthy
approved these changes
May 11, 2023
Documentation preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a property based on a new enumeration in order to provide a clearer definition of the data formats supported by each op. It doesn't use the existing
supportsproperty/flags, sinceCPUandGPUbecome confusing in the context of data types that can exist on either host or device (likeTensorTables backed by Tensorflow and Torch tensors.)We'll later remove the
supportsproperty, but keeping it here for now allows us to make this change more incrementally.Depends on: NVIDIA-Merlin/core#280