Convert data formats before executing each op in LocalExecutor
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
changed the title
LocalExecutor
karlhigley
changed the title
LocalExecutorLocalExecutor
karlhigley
force-pushed
the
feature/data-format-conversion
branch
from
cc1d04c to
5a24861
Compare
Documentation preview |
oliverholworthy
approved these changes
May 11, 2023
oliverholworthy
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us closer to a point where we can get rid of the custom code for running NVTabular Workflows at serving time by incorporating some of the functionality found there directly into
LocalExecutor. In particular,LocalExecutornow checks the data formats supported by each operator and converts the input data to one of the supported formats if necessary.Depends on: #279