Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase upper bound of pandas version from 1.4 to 1.6 #210

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented Feb 6, 2023

Increase upper bound of pandas version from 1.4 to 1.6.

Motivation: support latest version of cudf where the upper bound is 1.6 now.

When installing merlin-core in a rapids 22.12 environment you'll get an error about pandas incompatibility from the dependency resolver. dask-sql since 2022.9.0 has had a min version of 1.4.0. While we don't currently depend on this directly in Merlin code, this might be something users of our libraries might wish to use.

Max version previously set in #59 based on cudf compatibility. Since, cudf now supports up to 1.6, I think we can try out increasing our version to match

@oliverholworthy oliverholworthy added the chore Maintenance for the repository label Feb 6, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.02 milestone Feb 6, 2023
@oliverholworthy oliverholworthy self-assigned this Feb 6, 2023
@karlhigley karlhigley merged commit 6b9019f into NVIDIA-Merlin:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants