Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict running on pandas 1.4.x #59

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Restrict running on pandas 1.4.x #59

merged 1 commit into from
Apr 4, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Apr 4, 2022

We've seen some issues with pandas 1.4 in merlin-models, and it looks
like its also not supported by cudf yet

https://github.com/rapidsai/cudf/blob/adec5356b4177467512ba5b95d09f64e03762cdb/conda/recipes/cudf/meta.yaml#L45

pin to <1.4.x like cudf

We've seen some issues with pandas 1.4 in merlin-models, and it looks
like its also not supported by cudf yet

https://github.com/rapidsai/cudf/blob/adec5356b4177467512ba5b95d09f64e03762cdb/conda/recipes/cudf/meta.yaml#L45

pin to <1.4.x like cudf
@nvidia-merlin-bot
Copy link

Click to view CI Results
GitHub pull request #59 of commit dfe8d06fd125c9d6b554bfe32fcd64ffc9df5c85, no merge conflicts.
Running as SYSTEM
Setting status of dfe8d06fd125c9d6b554bfe32fcd64ffc9df5c85 to PENDING with url https://10.20.13.93:8080/job/merlin_core/9/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_core
using credential ce87ff3c-94f0-400a-8303-cb4acb4918b5
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/core # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/core
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems username and pass
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/core +refs/pull/59/*:refs/remotes/origin/pr/59/* # timeout=10
 > git rev-parse dfe8d06fd125c9d6b554bfe32fcd64ffc9df5c85^{commit} # timeout=10
Checking out Revision dfe8d06fd125c9d6b554bfe32fcd64ffc9df5c85 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f dfe8d06fd125c9d6b554bfe32fcd64ffc9df5c85 # timeout=10
Commit message: "Restrict running on pandas 1.4.x"
 > git rev-list --no-walk 3a700dab808aedddbe602c209ee58851e15574ad # timeout=10
[merlin_core] $ /bin/bash /tmp/jenkins6162152072395358734.sh
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Requirement already satisfied: setuptools in /usr/local/lib/python3.8/dist-packages (60.9.3)
Collecting setuptools
  Downloading setuptools-61.3.1-py3-none-any.whl (1.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.1/1.1 MB 12.7 MB/s eta 0:00:00
Installing collected packages: setuptools
  Attempting uninstall: setuptools
    Found existing installation: setuptools 60.9.3
    Uninstalling setuptools-60.9.3:
      Successfully uninstalled setuptools-60.9.3
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
google-auth 1.35.0 requires cachetools<5.0,>=2.0.0, but you have cachetools 5.0.0 which is incompatible.
tensorflow-gpu 2.8.0 requires keras<2.9,>=2.8.0rc0, but you have keras 2.6.0 which is incompatible.
tensorflow-gpu 2.8.0 requires tensorboard<2.9,>=2.8, but you have tensorboard 2.6.0 which is incompatible.
Successfully installed setuptools-61.3.1
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_core/core, configfile: pyproject.toml
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 337 items / 1 skipped

tests/unit/core/test_dispatch.py .. [ 0%]
tests/unit/dag/test_base_operator.py .... [ 1%]
tests/unit/dag/test_column_selector.py .......................... [ 9%]
tests/unit/dag/test_tags.py ...... [ 11%]
tests/unit/dag/ops/test_selection.py ... [ 12%]
tests/unit/io/test_io.py ............................................... [ 26%]
................................................................ [ 45%]
tests/unit/schema/test_column_schemas.py ............................... [ 54%]
........................................................................ [ 75%]
........................................................................ [ 97%]
[ 97%]
tests/unit/schema/test_schema_io.py .. [ 97%]
tests/unit/utils/test_utils.py ........ [100%]

=============================== warnings summary ===============================
tests/unit/dag/test_base_operator.py: 4 warnings
tests/unit/io/test_io.py: 73 warnings
/usr/lib/python3.8/site-packages/cudf/core/dataframe.py:1253: UserWarning: The deep parameter is ignored and is only included for pandas compatibility.
warnings.warn(

tests/unit/io/test_io.py: 145 warnings
/var/jenkins_home/.local/lib/python3.8/site-packages/partd-1.2.0-py3.8.egg/partd/pandas.py:113: DeprecationWarning: The Index._get_attributes_dict method is deprecated, and will be removed in a future version
header = (type(ind), ind._get_attributes_dict(), values.dtype, cat)

tests/unit/io/test_io.py::test_validate_and_regenerate_dataset
/var/jenkins_home/workspace/merlin_core/core/merlin/io/parquet.py:535: DeprecationWarning: 'ParquetDataset.pieces' attribute is deprecated as of pyarrow 5.0.0 and will be removed in a future version. Specify 'use_legacy_dataset=False' while constructing the ParquetDataset, and then use the '.fragments' attribute instead.
paths = [p.path for p in pa_dataset.pieces]

tests/unit/utils/test_utils.py::test_nvt_distributed[True-True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 44553 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[True-False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 34029 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[False-True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 35529 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[False-False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 43261 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed_force[True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 35821 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed_force[False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 40053 instead
warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================ 337 passed, 1 skipped, 229 warnings in 52.68s =================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/core/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_core] $ /bin/bash /tmp/jenkins1767295286710122540.sh

@marcromeyn marcromeyn self-requested a review April 4, 2022 15:46
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-59

@benfred benfred merged commit 8a1a07d into main Apr 4, 2022
@benfred benfred deleted the pandas_ver branch April 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants