Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check for array types in is_list_dtype #253

Conversation

oliverholworthy
Copy link
Member

Follow-up to #251

Improve check for array types in is_list_dtype

This change handle different versions of pandas by removing the use of pandas is_list_like function and instead checking the shape of the array passed in.

To handle different versions of pandas by removing the use of pandas is_list_like
@oliverholworthy oliverholworthy added the chore Maintenance for the repository label Mar 21, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.03 milestone Mar 21, 2023
@oliverholworthy oliverholworthy self-assigned this Mar 21, 2023
@karlhigley karlhigley merged commit 8df89bc into NVIDIA-Merlin:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants