Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check for array types in is_list_dtype #253

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Improve check for array types in is_list_dtype #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions merlin/core/dispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,8 @@ def is_list_dtype(ser):
return pd.api.types.is_list_like(ser.values[0])
elif cudf and isinstance(ser, (cudf.Series, cudf.ListDtype)):
return cudf_is_list_dtype(ser)
elif cudf and isinstance(ser, cp.ndarray):
return pd.api.types.is_list_like(ser[0])
elif isinstance(ser, np.ndarray):
return pd.api.types.is_list_like(ser[0])
elif isinstance(ser, np.ndarray) or (cp and isinstance(ser, cp.ndarray)):
return len(ser.shape) > 1
return pd.api.types.is_list_like(ser)


Expand Down