Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Release Draft on release branch builds #925

Conversation

oliverholworthy
Copy link
Member

  • Publish Release Draft on release branch builds
  • And add name-template based on resolved version

@oliverholworthy oliverholworthy added this to the Merlin 22.12 milestone Dec 15, 2022
@oliverholworthy oliverholworthy self-assigned this Dec 15, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-925

tags:
- v*
release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with on.push.release. I skimmed a bit at the foll URL. Would on.push.branches: - release-* work?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an unfortunate typo! You're right that branches is the one we're after I think.

@oliverholworthy oliverholworthy merged commit 0bd366f into NVIDIA-Merlin:main Dec 19, 2022
oliverholworthy added a commit that referenced this pull request Dec 19, 2022
* Publish release draft on relase branch builds as well as tag

* Add name-template to release-drafter.yml

* Correct push name s/release/branches/

* Wrap branch name in quotes to match GitHub docs recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants