Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Release Draft on release branch builds #925

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Publish Release Draft on release branch builds #925

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4af982d
Publish release draft on relase branch builds as well as tag
oliverholworthy Dec 15, 2022
6c4d580
Add name-template to release-drafter.yml
oliverholworthy Dec 15, 2022
7afc6ed
Correct push name s/release/branches/
oliverholworthy Dec 15, 2022
013baf7
Wrap branch name in quotes to match GitHub docs recommendation
oliverholworthy Dec 15, 2022
1cad40b
Merge branch 'main' into release-draft-publish-on-release-branch
oliverholworthy Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
name-template: 'v$RESOLVED_VERSION'
categories:
- title: '⚠ Breaking Changes'
labels:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-drafter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ name: release-drafter

on:
push:
# trigger on tags only
tags:
- v*
release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with on.push.release. I skimmed a bit at the foll URL. Would on.push.branches: - release-* work?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an unfortunate typo! You're right that branches is the one we're after I think.

- release*

workflow_dispatch:

Expand Down