Fix Python3.11 tests #5196
Merged
Fix Python3.11 tests #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [11011153]: BUILD STARTED |
awolant
approved these changes
Nov 24, 2023
- moves to a newer PaddlePaddle version that supports Python3.11 - moves to a newer OpenCV version that supports Python3.11 - fixes deprecated the usage of inspect.getargspec on nose Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_python3.11
branch
from
f14eb51
to
c640905
Compare
|
CI MESSAGE: [11011153]: BUILD PASSED |
|
CI MESSAGE: [11016116]: BUILD STARTED |
mzient
reviewed
Nov 24, 2023
| @@ -45,7 +45,7 @@ def assert_stmt(expression1, expression2): | |||
| """ | |||
| if not callable(expression2): | |||
| raise ValueError('{} must be a callable'.format(expression2)) | |||
| args, _, keywords, _ = inspect.getargspec(expression2) | |||
| args, _, keywords, _, _, _, _ = inspect.getfullargspec(expression2) | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| args, _, keywords, _, _, _, _ = inspect.getfullargspec(expression2) | |
| args, _, keywords, *_ = inspect.getfullargspec(expression2) |
?
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
mzient
reviewed
Nov 24, 2023
| if sys.version_info >= (3, 10) and not hasattr(collections, "Callable"): | ||
| nose.case.collections = collections.abc | ||
| nose.inspector.collections = collections.abc | ||
| nose.loader.collections = collections.abc | ||
| nose.suite.collections = collections.abc | ||
| nose.plugins.attrib.collections = collections.abc | ||
| if sys.version_info >= (3, 11): |
There was a problem hiding this comment.
Total nitpick: some empty lines to separate those rather unrelated workarounds.
mzient
approved these changes
Nov 24, 2023
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [11018266]: BUILD STARTED |
|
CI MESSAGE: [11016116]: BUILD PASSED |
|
CI MESSAGE: [11018266]: BUILD FAILED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A