Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Nemo examples fix #2293

Merged
merged 6 commits into from
Jan 19, 2024
Merged

[2.4] Nemo examples fix #2293

merged 6 commits into from
Jan 19, 2024

Conversation

holgerroth
Copy link
Collaborator

@holgerroth holgerroth commented Jan 18, 2024 •
edited
Loading

Fixes # .

Description

Update the used NeMo versions for each example. Improve the instructions.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen chesterxgchen changed the title Nemo examples fix [2.4] Nemo examples fix Jan 18, 2024
chesterxgchen
chesterxgchen approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth holgerroth marked this pull request as draft January 18, 2024 00:35
chesterxgchen
chesterxgchen approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth holgerroth marked this pull request as ready for review January 19, 2024 00:42
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) January 19, 2024 00:45
@holgerroth holgerroth merged commit 024a1b7 into NVIDIA:2.4 Jan 19, 2024
15 checks passed
@holgerroth holgerroth deleted the nemo_fix branch January 20, 2024 05:51
@holgerroth holgerroth mentioned this pull request Jan 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerroth @chesterxgchen