Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply nemo 2.4 fixes #2327

Merged
merged 2 commits into from
Jan 29, 2024
Merged

apply nemo 2.4 fixes #2327

merged 2 commits into from
Jan 29, 2024

Conversation

holgerroth
Copy link
Collaborator

@holgerroth holgerroth commented Jan 29, 2024 •
edited
Loading

Fixes # .

Description

Merge recent fixes (PR, PR. PR) to NeMo examples to main.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) January 29, 2024 18:29
chesterxgchen
chesterxgchen approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth merged commit 3589df1 into NVIDIA:main Jan 29, 2024
16 checks passed
@holgerroth holgerroth deleted the nemo_updates branch January 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerroth @chesterxgchen