Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Fix nemo peft notebook #2296

Merged
merged 2 commits into from
Jan 20, 2024
Merged

[2.4] Fix nemo peft notebook #2296

merged 2 commits into from
Jan 20, 2024

Conversation

holgerroth
Copy link
Collaborator

Fixes # .

Description

Add spawn start method to enable simulation with NeMo models.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth holgerroth changed the base branch from main to 2.4 January 20, 2024 00:32
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth enabled auto-merge (squash) January 20, 2024 01:03
@holgerroth holgerroth requested a review from ZiyueXu77 January 20, 2024 01:04
@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth merged commit 4dd8132 into NVIDIA:2.4 Jan 20, 2024
15 checks passed
@holgerroth holgerroth deleted the fix_nemo_peft_nb branch January 20, 2024 05:51
@holgerroth holgerroth mentioned this pull request Jan 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerroth @chesterxgchen