Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Update nemo instructions #2298

Merged
merged 3 commits into from
Jan 22, 2024
Merged

[2.4] Update nemo instructions #2298

merged 3 commits into from
Jan 22, 2024

Conversation

holgerroth
Copy link
Collaborator

@holgerroth holgerroth commented Jan 22, 2024 •
edited
Loading

Fixes # .

Description

  • Update instructions to include docker run commands recommended by NeMo.
  • Add hardware requirement sections.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth holgerroth changed the title Update nemo instructions [2.4] Update nemo instructions Jan 22, 2024
@holgerroth holgerroth enabled auto-merge (squash) January 22, 2024 19:04
@holgerroth
Copy link
Collaborator Author

/build

ZiyueXu77
ZiyueXu77 previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth holgerroth requested a review from ZiyueXu77 January 22, 2024 19:33
@holgerroth holgerroth merged commit 45c7adb into NVIDIA:2.4 Jan 22, 2024
15 checks passed
@holgerroth holgerroth deleted the update_nemo_instructions branch January 22, 2024 19:36
@holgerroth holgerroth mentioned this pull request Jan 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerroth @ZiyueXu77