[2.4] Move workspace setup inside constructor #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanTingHsieh
changed the title
YuanTingHsieh
requested review from
chesterxgchen,
IsaacYangSLA,
SYangster,
nvkevlu,
yanchengnv and
nvidianz
|
/build |
1 similar comment
|
/build |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Line 354
run_status = self._get_return_code(return_dict, process, self.workspace)is running in the main process whilethe workspace was being setup in the forked process.
Then this workspace setup will not be reflected back into the main process.
We move the workspace setup code inside the class constructor to solve this problem.
Types of changes
./runtest.sh.