Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move simulator workspace setup inside constructor #2311

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Move simulator workspace setup inside constructor #2311

merged 1 commit into from
Jan 24, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Main branch version of PR #2308

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit 0b1ce62 into NVIDIA:main Jan 24, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_simulator_runner branch January 24, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yhwen yhwen Awaiting requested review from yhwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @chesterxgchen