Enhance flexibility by passing callbacks as method argument #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal2409
force-pushed
the
callback_fix
branch
from
acbe3d7
to
c748a8c
Compare
janekl
force-pushed
the
callback_fix
branch
2 times, most recently
from
5e24036
to
1b588da
Compare
|
@titu1994 could you also please help to review this? Short one, focusing on UX |
titu1994
reviewed
Dec 14, 2023
| @@ -95,10 +95,10 @@ def _plugins(self) -> list: | |||
|
|
|||
| return plugins | |||
|
|
|||
| def create_trainer(self) -> Trainer: | |||
| def create_trainer(self, callbacks=(CustomProgressBar(),)) -> Trainer: | |||
There was a problem hiding this comment.
Don't instantiate objects in function signature. Default to None, check if None inside the function and the. Instantiate the value you need. Only primitive values are safe in function signature. https://leimao.github.io/blog/Python-Default-Argument-Mutable-Object/
michal2409
force-pushed
the
callback_fix
branch
2 times, most recently
from
a1d1471
to
f513a32
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
|
@titu1994 could you have another look? |
Signed-off-by: Michal Futrega <michal.futrega@gmail.com>
Signed-off-by: Michal Futrega <michal.futrega@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
) * Enhance flexibility by passing callbacks as method argument Signed-off-by: Michal Futrega <michal.futrega@gmail.com> * Set callbacks default to None Signed-off-by: Michal Futrega <michal.futrega@gmail.com> --------- Signed-off-by: Michal Futrega <michal.futrega@gmail.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR enhances the flexibility of CustomProgressBar by modifying the create_trainer method to accept callbacks as a method argument, replacing its previous fixed implementation.
Collection: NLP
Changelog
Moved callbacks to method arguement.
Usage
N/A
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information