Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance flexibility by passing callbacks as method argument #8015

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Enhance flexibility by passing callbacks as method argument #8015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c46fe
Enhance flexibility by passing callbacks as method argument
michal2409 Dec 12, 2023
8580f0f
Set callbacks default to None
michal2409 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nemo/collections/nlp/parts/megatron_trainer_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,12 @@ def _plugins(self) -> list:

return plugins

def create_trainer(self) -> Trainer:
def create_trainer(self, callbacks=None) -> Trainer:
strategy = self._training_strategy()
plugins = self._plugins()
return Trainer(plugins=plugins, strategy=strategy, **self.cfg.trainer, callbacks=[CustomProgressBar()])
if callbacks is None:
callbacks = [CustomProgressBar()]
return Trainer(plugins=plugins, strategy=strategy, **self.cfg.trainer, callbacks=callbacks)


class MegatronBertTrainerBuilder(MegatronTrainerBuilder):
Expand Down
Loading