Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiler warnings #171

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

PointKernel
Copy link
Member

This PR enables compiler warnings when building cuco benchmarks, examples, and tests. It helps get rid of unexpected errors when building RAPIDS projects where all warnings are treated as errors.

@PointKernel PointKernel added type: feature request New feature request helps: rapids Helps or needed by RAPIDS topic: build CMake build issue labels Jun 3, 2022
@PointKernel PointKernel requested a review from vyasr June 3, 2022 17:50
@PointKernel PointKernel merged commit 5502903 into NVIDIA:dev Jun 6, 2022
@PointKernel PointKernel deleted the enable-compiler-warnings branch June 6, 2022 16:59
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Jun 7, 2022
Depends on NVIDIA/cuCollections#165 and NVIDIA/cuCollections#171

This is a preparation step to finally address #10841. It fetches the latest version of `cuco` that [adds missing thrust headers ](NVIDIA/cuCollections#161) and [improves `static_map::retrieve_all`](NVIDIA/cuCollections#169).

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #10983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helps: rapids Helps or needed by RAPIDS topic: build CMake build issue type: feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant