Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update to Thrust 1.16 #10841

Closed
robertmaynard opened this issue May 12, 2022 · 4 comments · Fixed by #11437
Closed

[FEA] Update to Thrust 1.16 #10841

robertmaynard opened this issue May 12, 2022 · 4 comments · Fixed by #11437
Assignees
@bdice
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@robertmaynard
Copy link
Contributor

We want to update the version of Thrust from 1.15 to 1.16 (changelog). This update is needed to fix compilation with GCC 11, because of some warnings-as-errors present in Thrust 1.15 with GCC 11 (such as this one from Thrust's copy of cub: NVIDIA/cub#418).

Describe the solution you'd like
As documented in #10586 the steps required are:

  1. Try to work out whatever issues with CMake / include paths may exist.
  2. Prepare all rapids-cmake repos for Thrust 1.16 compatibility. So far rmm (Clean up Thrust includes. rmm#1011) has been merged, and cuml is in progress ( Clean up Thrust includes. cuml#4675). Outstanding is cuCollections, raft, cuSpatial, and cuGraph.
  3. Upgrade libcudf to Thrust 1.16 again (re-apply the updated patch in Update to Thrust 1.16 #10489, revert Update to Thrust 1.16 #10489 )
  4. Upgrade rapids-cmake to Thrust 1.16.
@robertmaynard robertmaynard added feature request New feature or request Needs Triage Need team to review and classify labels May 12, 2022
@bdice
Copy link
Contributor

bdice commented May 12, 2022

Thanks for writing this up @robertmaynard! I can open the PRs for other repos soon - the time consuming part is self-review to make sure that the #includes are reasonably organized while keeping the diffs as minimal as possible.

@vyasr vyasr mentioned this issue May 12, 2022
Merged
@robertmaynard
Copy link
Contributor Author

cugraph is now in progress rapidsai/cugraph#2310

@robertmaynard robertmaynard mentioned this issue May 25, 2022
Closed
5 tasks
@bdice
Copy link
Contributor

bdice commented May 25, 2022

So are cuML (rapidsai/cuml#4675), cuspatial (rapidsai/cuspatial#539), cuco (NVIDIA/cuCollections#161), raft (rapidsai/raft#678). I am planning to commit a custom rapids-cmake versions.json and let CI test these packages with thrust 1.17-rc2, then revert those changes before merging.

@bdice bdice mentioned this issue May 26, 2022
Closed
8 tasks
@PointKernel PointKernel mentioned this issue May 26, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 7, 2022
@PointKernel
Update cuCollections for thrust upgrade (#10983)
20b07bf 
Depends on NVIDIA/cuCollections#165 and NVIDIA/cuCollections#171

This is a preparation step to finally address #10841. It fetches the latest version of `cuco` that [adds missing thrust headers ](NVIDIA/cuCollections#161) and [improves `static_map::retrieve_all`](NVIDIA/cuCollections#169).

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #10983
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@GregoryKimball GregoryKimball added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jun 28, 2022
@bdice bdice mentioned this issue Aug 2, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 11, 2022
@bdice
Update to Thrust 1.17.0 (#11437)
0df6178 
Updates the bundled version of Thrust to 1.17.0. I will run benchmarks and include results in a comment below.

Depends on #11457.

Supersedes #10489, #10577, #10586. Closes #10841. **This should be merged concurrently with rapidsai/rapids-cmake#231

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #11437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdice bdice

Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Thrust 1.17.0 bdice/cudf
3 participants
@robertmaynard @bdice @GregoryKimball