Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi gpu example #304

Merged
merged 8 commits into from
Jan 3, 2025
Merged

multi gpu example #304

merged 8 commits into from
Jan 3, 2025

Conversation

amwi04
Copy link
Collaborator

@amwi04 amwi04 commented Dec 16, 2024

  1. GPU will perform vector_add
  2. GPU will perform vector_substract

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 16, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amwi04 amwi04 mentioned this pull request Dec 16, 2024
Closed
@leofang leofang self-requested a review December 16, 2024 16:13
@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Dec 16, 2024
@leofang leofang added this to the cuda.core beta 3 milestone Dec 16, 2024
@leofang leofang requested a review from vzhurba01 December 16, 2024 20:20
@leofang leofang linked an issue Dec 17, 2024 that may be closed by this pull request
Add a simple multi-GPU code sample based on cuda.core #154
Closed
leofang
leofang requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Amod! I left some comments.

@leofang
Copy link
Member

leofang commented Jan 2, 2025

/ok to test

(we don't have multi-GPU CIs yet, so this is just testing if the skip condition is correct)

@leofang
Copy link
Member

leofang commented Jan 2, 2025

/ok to test

leofang
leofang previously approved these changes Jan 2, 2025
View reviewed changes
@leofang
Copy link
Member

leofang commented Jan 2, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Jan 2, 2025

/ok to test

leofang
leofang approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for help @amwi04! Let's merge.

@leofang leofang merged commit a817969 into NVIDIA:main Jan 3, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 vzhurba01 left review comments

@leofang leofang leofang approved these changes

Assignees

@amwi04 amwi04

Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

Add a simple multi-GPU code sample based on cuda.core
3 participants
@amwi04 @leofang @vzhurba01