-
Notifications
You must be signed in to change notification settings - Fork 181
Add get_cuda_native_handle
#773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(added a short benchmark to the PR description) |
/ok to test 8970dca |
/ok to test 4ca551c |
@@ -287,6 +288,7 @@ def prep_extensions(sources, libraries): | |||
|
|||
# new path for the bindings from cybind | |||
def rename_architecture_specific_files(): | |||
path = os.path.join("cuda", "bindings", "_internal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a bug fix exposed by the new line 224. Previously, the path
variable happened to be right (leaking from the loop variable at line 227), but it's not longer correct after we append one more item to path_list
.
This comment has been minimized.
This comment has been minimized.
Decision to make: Should we raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision to make: Should we raise
DeprecationWarning
in__int__()
? It can be very noisy but it's the only effective way for us to inform users about the deprecation.
Do we want to give users a grace period, in case they need to support two cuda-bindings versions for a while?
Concretely:
In the next release, deprecate only in the documentation.
Only with the next minor release bump: actually raise DeprecationWarning
.
/ok to test 53055e5 |
@leofang WDYT about introducing a "Phased deprecations" section somewhere, so we don't forget in the future. E.g. for this case:
|
|
Yup that's great idea, tracked in #775. |
Description
closes #564
The performance is comparable to the existing
int()
approach (O(10) ns):Checklist