Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new gates to Photonics simulator #2289

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Add new gates to Photonics simulator #2289

merged 9 commits into from
Oct 30, 2024

Conversation

Omar-ORCA
Copy link
Contributor

  • Added create and annihilate photonic gates
  • Updated examples

@Omar-ORCA
Add new gates
c17d94c 
Signed-off-by: Omar Bacarreza <obacarreza@orcacomputing.com>
@Omar-ORCA
Change to = <init-expr>; style
0443255 
Signed-off-by: Omar Bacarreza <obacarreza@orcacomputing.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Omar-ORCA
Fix photonic state indexing
d2b57f1 
Signed-off-by: Omar Bacarreza <obacarreza@orcacomputing.com>
@Omar-ORCA
Formatting
a849dd9 
Signed-off-by: Omar Bacarreza <obacarreza@orcacomputing.com>
Omar-ORCA and others added 2 commits October 18, 2024 15:38
@Omar-ORCA
Python formatting
3ca35c9 
Signed-off-by: Omar Bacarreza <obacarreza@orcacomputing.com>
@khalatepradnya
Merge branch 'main' into photonics_add_gates
c4f2d33
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 22, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 23, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

khalatepradnya
khalatepradnya approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 24, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bettinaheim
bettinaheim approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the files under code ownership - Pradnya reviewed the rest.

@khalatepradnya khalatepradnya enabled auto-merge (squash) October 30, 2024 20:22
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 30, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya merged commit 81dd6fb into NVIDIA:main Oct 30, 2024
198 checks passed
@Omar-ORCA Omar-ORCA deleted the photonics_add_gates branch October 31, 2024 08:34
@khalatepradnya khalatepradnya mentioned this pull request Nov 4, 2024
Merged
@1tnguyen 1tnguyen mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalatepradnya khalatepradnya khalatepradnya approved these changes

@bettinaheim bettinaheim bettinaheim approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@boschmitt boschmitt Awaiting requested review from boschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Omar-ORCA @khalatepradnya @bettinaheim