Skip to content

Several fixes needed to compile cuOpt with LLVM #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 3 commits into from
Jul 2, 2025
Merged

Several fixes needed to compile cuOpt with LLVM #121

rapids-bot merged 3 commits into from
Jul 2, 2025

Conversation

@vitor1001
Copy link
Contributor

@vitor1001 vitor1001 commented Jun 24, 2025

  • add std:: prefix to min() and max();
  • add missing headers;
  • avoid calling std::optional::value() on device code since it can throw exceptions;
  • add "template" keyword to help parsing;
  • use a constexpr static method to define init_data(), to avoid using a not-yet-finished classes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@vitor1001 vitor1001 requested a review from a team as a code owner June 24, 2025 11:56
@vitor1001 vitor1001 requested review from akifcorduk and hlinsen June 24, 2025 11:56
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jun 24, 2025

Thank you @vitor1001 for the PR, one of the reviewers should be reviewing it shortly.

@aliceb-nv aliceb-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 25, 2025
@aliceb-nv
Copy link
Contributor

aliceb-nv commented Jun 25, 2025

/ok to test 69b3d8a

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jun 25, 2025

note: updated the PR with check-style fixes

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 1, 2025

Hi @aliceb-nv! Is there anything else you need from my side to merge this PR?

@anandhkb anandhkb added this to the 25.08 milestone Jul 1, 2025
rg20
rg20 reviewed Jul 1, 2025
View reviewed changes
cpp/src/mip/presolve/load_balanced_bounds_presolve.cu Outdated

#include <cub/cub.cuh>
#include <nvtx3/nvtx3.hpp>
// #include <nvtx3/nvtx3.hpp>
Copy link
Contributor

@rg20 rg20 Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented line

Copy link
Contributor Author

@vitor1001 vitor1001 Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed.

hlinsen
hlinsen reviewed Jul 1, 2025
View reviewed changes
@hlinsen
Copy link
Contributor

hlinsen commented Jul 1, 2025

/ok to test c5c8a0c

@vitor1001
Several fixes needed to compile cuOpt with LLVM:
e3e7378 
- add std:: prefix to min() and max();
- add missing headers;
- avoid calling std::optional::value() on device code since it can throw exceptions;
- add "template" keyword to help parsing;
- use a constexpr static method to define init_data(), to avoid using a not-yet-finished classes.
@hlinsen
Copy link
Contributor

hlinsen commented Jul 1, 2025

/ok to test 9261b22

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 2, 2025

@hlinsen it looks like the single Python test breakage is a flaky test. Doesn't look related to any of the changes.

@hlinsen
Copy link
Contributor

hlinsen commented Jul 2, 2025

@hlinsen it looks like the single Python test breakage is a flaky test. Doesn't look related to any of the changes.

I confirm it is not related. I am re running the tests.

@hlinsen
Copy link
Contributor

hlinsen commented Jul 2, 2025

/ok to test dd94656

@hlinsen
Copy link
Contributor

hlinsen commented Jul 2, 2025

/merge

@rapids-bot rapids-bot bot merged commit e0dc603 into NVIDIA:branch-25.08 Jul 2, 2025
72 checks passed
@vitor1001 vitor1001 mentioned this pull request Aug 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rg20 rg20 rg20 left review comments

@hlinsen hlinsen hlinsen approved these changes

@akifcorduk akifcorduk Awaiting requested review from akifcorduk akifcorduk is a code owner automatically assigned from NVIDIA/cuopt-engine-codeowners

Assignees

@vitor1001 vitor1001

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

6 participants

@vitor1001 @rgsl888prabhu @aliceb-nv @hlinsen @rg20 @anandhkb