Skip to content

Update cxxopts to v3.3.1 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 10 commits into from
Jul 11, 2025
Merged

Update cxxopts to v3.3.1 #128

rapids-bot merged 10 commits into from
Jul 11, 2025

Conversation

@vitor1001
Copy link
Contributor

@vitor1001 vitor1001 commented Jun 25, 2025 •
edited by rgsl888prabhu
Loading

cxxopts to v3.3.1

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@vitor1001 vitor1001 requested a review from a team as a code owner June 25, 2025 09:01
@vitor1001 vitor1001 requested review from chris-maes and rg20 June 25, 2025 09:01
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 25, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 1, 2025

Hi! Is this PR OK in principle? Who is supposed to review this? Adding @Kh4ster (hopefully)...

@anandhkb anandhkb added this to the 25.08 milestone Jul 1, 2025
@rg20 rg20 requested review from akifcorduk and removed request for chris-maes and rg20 July 1, 2025 14:41
@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 4, 2025

@akifcorduk, can you have a look?

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 9, 2025

Hi! @rg20 or @akifcorduk, can you have a look?

@rg20 rg20 added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 9, 2025
akifcorduk
akifcorduk approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@akifcorduk akifcorduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akifcorduk
Copy link
Contributor

akifcorduk commented Jul 9, 2025

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 9, 2025

/ok to test

@akifcorduk, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@akifcorduk
Copy link
Contributor

akifcorduk commented Jul 9, 2025

/ok to test acf9bb7

@akifcorduk
Copy link
Contributor

akifcorduk commented Jul 9, 2025

@vitor1001 please do the clang formatting as style checks are failing.

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 9, 2025

@vitor1001 please do the clang formatting as style checks are failing.

@akifcorduk done!

@rg20
Copy link
Contributor

rg20 commented Jul 9, 2025

/ok to test ad9725f

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 9, 2025

The check-style wants me to add a copyright notice to a third-party lib. Not sure it's the right thing to do.

@rg20
Copy link
Contributor

rg20 commented Jul 9, 2025 •
edited
Loading

The check-style wants me to add a copyright notice to a third-party lib. Not sure it's the right thing to do.

@vitor1001 you can disable style checker for cxxopt

Please see example here: https://github.com/rapidsai/cudf/blob/4d2d0ae4a41165568148d31e2f19bf19129c879f/.pre-commit-config.yaml#L55

@rgsl888prabhu for viz!

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 9, 2025

Also @vitor1001 Can you please add the copyright to this file as well https://github.com/NVIDIA/cuopt/blob/branch-25.08/thirdparty/THIRD_PARTY_LICENSES

@vitor1001 vitor1001 requested a review from a team as a code owner July 9, 2025 16:35
@vitor1001 vitor1001 requested a review from jameslamb July 9, 2025 16:35
@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 9, 2025

@rg20 @rgsl888prabhu both suggestions done!

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 9, 2025

Thank you @vitor1001

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 9, 2025

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 9, 2025

/ok to test

@rgsl888prabhu, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 9, 2025

/ok to test d4a5f64

bdice
bdice approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please list the version number that is being used here? “Latest” won’t mean anything to future readers of this PR.

Also, for reference, I updated this in RMM recently. rapidsai/rmm#1962

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 11, 2025

Can you please list the version number that is being used here? “Latest” won’t mean anything to future readers of this PR.

Also, for reference, I updated this in RMM recently. rapidsai/rmm#1962

@vitor1001 May I request you to address this question? And then we are good to merge the PR.

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 11, 2025

Hi @rgsl888prabhu !

It's 44380e5a44706ab7347f400698c703eb2a196202.

@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 11, 2025

Hi @rgsl888prabhu !

It's 44380e5a44706ab7347f400698c703eb2a196202.

Hi @rgsl888prabhu !

It's 44380e5a44706ab7347f400698c703eb2a196202.

If I am not wrong, that is 3.3.1

@vitor1001
Copy link
Contributor Author

vitor1001 commented Jul 11, 2025

If I am not wrong, that is 3.3.1

Indeed, good point.

@vitor1001 vitor1001 changed the title Update cxxopts to its latests version from GitHub Update cxxopts to v3.3.1 version from GitHub Jul 11, 2025
@vitor1001 vitor1001 changed the title Update cxxopts to v3.3.1 version from GitHub Update cxxopts to v3.3.1 Jul 11, 2025
@rgsl888prabhu
Copy link
Collaborator

rgsl888prabhu commented Jul 11, 2025

/merge

@rapids-bot rapids-bot bot merged commit e5dd284 into NVIDIA:branch-25.08 Jul 11, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@akifcorduk akifcorduk akifcorduk approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from NVIDIA/cuopt-ci-codeowners

Assignees

No one assigned

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

6 participants

@vitor1001 @akifcorduk @rg20 @rgsl888prabhu @bdice @anandhkb