Fix compile error when using clang with C++20.
#145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extents type of the left hand side of those assignment are `extents<i_t, FJ_MOVE_SIZE, raft::dynamic_extent>`. But the extents type created on the right hand side by `raft::make_extents<i_t>((i_t)FJ_MOVE_SIZE, (i_t)fj.pb_ptr->n_variables))` are `extents<int, dynamic_extents, dynamic_extents>`. The former is constructible from the latter, but the documentation specific that this conversion is *explicit*: "This constructor is explicit if `((Extents != std::dynamic_extent && OtherExtents == std::dynamic_extent) || ...)` is true" The above condition holds in our case: (`FJ_MOVE_SIZE != dynamic_extent && dynamic_extents == dynamic_extent)` for the first extent. This ctor being explicit translates to the ctor of the mdspan being explicit, so in C++20, when the compiler enforces explicitness, we need to give it the exact extents type.
aliceb-nv
added
non-breaking
Contributor
|
/ok to test 810cb78 |
Collaborator
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extents type of the left hand side of those assignment are
extents<i_t, FJ_MOVE_SIZE, raft::dynamic_extent>. But the extents type created on the right hand side byraft::make_extents<i_t>((i_t)FJ_MOVE_SIZE, (i_t)fj.pb_ptr->n_variables))areextents<int, dynamic_extents, dynamic_extents>.The former is constructible from the latter, but the documentation specific that this conversion is explicit:
"This constructor is explicit if
((Extents != std::dynamic_extent && OtherExtents == std::dynamic_extent) || ...)is true"The above condition holds in our case: (
FJ_MOVE_SIZE != dynamic_extent && dynamic_extents == dynamic_extent)for the first extent.This ctor being explicit translates to the ctor of the mdspan being explicit, so in C++20, when the compiler enforces explicitness, we need to give it the exact extents type.