Fix out-of-bound access in clean_up_infeasibilities.
#346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This OOB access happens when the last element is the one being removed: the second access to `infeasibility_indices[k]` after the `pop_back` is invalid. This is another example for issue NVIDIA#150. Signed-off-by: Clement Courbet <courbet@google.com>
legrosbuffle
force-pushed
the
fix-vector-oob
branch
from
0b9eb2d to
1de0a95
Compare
rgsl888prabhu
added
bug
Collaborator
|
/ok to test 1de0a95 |
Collaborator
|
/ok to test 9e81244 |
Collaborator
|
/ok to test d669466 |
|
🔔 Hi @anandhkb @legrosbuffle, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
Collaborator
rg20
approved these changes
Sep 3, 2025
Contributor
|
/merge |
aliceb-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
This OOB access happens when the last element is the one being removed: the second access to `infeasibility_indices[k]` after the `pop_back` is invalid. This is another example for issue #150. Authors: - Clement Courbet (https://github.com/legrosbuffle) - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Rajesh Gandham (https://github.com/rg20) URL: #346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This OOB access happens when the last element is the one being removed: the second access to
infeasibility_indices[k]after thepop_backis invalid.This is another example for issue #150.