Skip to content

Fix out-of-bound access in clean_up_infeasibilities. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Sep 3, 2025
Merged

Fix out-of-bound access in clean_up_infeasibilities. #346

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de0a95
Fix out-of-bound access in `clean_up_infeasibilities`.
legrosbuffle Aug 25, 2025
9e81244
Update phase2.cpp
rgsl888prabhu Aug 25, 2025
d669466
Merge branch 'branch-25.10' into fix-vector-oob
rgsl888prabhu Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cpp/src/dual_simplex/phase2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,9 @@ void clean_up_infeasibilities(std::vector<f_t>& squared_infeasibilities,
const f_t squared_infeas = squared_infeasibilities[j];
if (squared_infeas == 0.0) {
// Set to the last element
const i_t sz = infeasibility_indices.size();
infeasibility_indices[k] = infeasibility_indices[sz - 1];
const i_t new_j = infeasibility_indices.back();
infeasibility_indices[k] = new_j;
infeasibility_indices.pop_back();
i_t new_j = infeasibility_indices[k];
if (squared_infeasibilities[new_j] == 0.0) { k--; }
}
}
Expand Down