Skip to content

Conversation

@chris-maes
Copy link
Contributor

This PR fixes two bugs discovered while testing the AMPL interface:

  1. We weren't correctly calculating the objective constant when presolve eliminated variables on a maximization problem.

Thanks to Alice for the quick fix!

  1. We had an undefined memory access on the number of nodes and simplex iterations when solving a MIP at the root node.

@chris-maes chris-maes requested a review from a team as a code owner May 30, 2025 17:31
@chris-maes chris-maes requested review from hlinsen and rg20 May 30, 2025 17:31
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes self-assigned this May 30, 2025
@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change labels May 30, 2025
@chris-maes chris-maes added this to the 25.05 milestone May 30, 2025
@chris-maes
Copy link
Contributor Author

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented May 30, 2025

/ok to test

@chris-maes, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rgsl888prabhu
Copy link
Collaborator

/ok to test 7565dd7

@chris-maes
Copy link
Contributor Author

/ok to test c6d9f6d

@chris-maes
Copy link
Contributor Author

/ok to test b0e612e

@chris-maes
Copy link
Contributor Author

/merge

1 similar comment
@chris-maes
Copy link
Contributor Author

/merge

@rgsl888prabhu rgsl888prabhu merged commit 09aa8c9 into NVIDIA:branch-25.05 Jun 3, 2025
162 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants