Skip to content

Fix obj constant on max. Fix undefined memory access at root #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgsl888prabhu merged 5 commits into from
Jun 3, 2025
Merged

Fix obj constant on max. Fix undefined memory access at root #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
854f3d4
Fix objective constant on maximization. Fix undefined memory access w…
chris-maes May 30, 2025
7565dd7
Merge branch 'branch-25.05' into ampl_fix_3
rgsl888prabhu Jun 2, 2025
97359ba
Style fixes
chris-maes Jun 2, 2025
c6d9f6d
Remove prefix from log file
chris-maes Jun 2, 2025
b0e612e
Merge branch 'branch-25.05-nvidia' into ampl_fix_3
chris-maes Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/src/dual_simplex/branch_and_bound.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,10 @@ mip_status_t branch_and_bound_t<i_t, f_t>::solve(mip_solution_t<i_t, f_t>& solut
global_variables::mutex_upper.unlock();
// We should be done here
uncrush_primal_solution(original_problem, original_lp, incumbent.x, solution.x);
solution.objective = incumbent.objective;
solution.lower_bound = lower_bound;
solution.objective = incumbent.objective;
solution.lower_bound = lower_bound;
solution.nodes_explored = 0;
solution.simplex_iterations = root_relax_soln.iterations;
settings.log.printf("Optimal solution found at root node. Objective %.16e. Time %.2f.\n",
compute_user_objective(original_lp, root_objective),
toc(start_time));
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/linear_programming/utilities/logger_init.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class init_logger_t {
// TODO save the defaul sink and restore it
cuopt::default_logger().sinks().push_back(
std::make_shared<rapids_logger::basic_file_sink_mt>(log_file, true));
cuopt::default_logger().set_pattern("%v");
cuopt::default_logger().flush_on(rapids_logger::level_enum::info);
}
}
~init_logger_t() { cuopt::reset_default_logger(); }
Expand Down
1 change: 1 addition & 0 deletions cpp/src/mip/presolve/trivial_presolve.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ void update_from_csr(problem_t<i_t, f_t>& pb)

// update objective_offset
pb.presolve_data.objective_offset +=
pb.presolve_data.objective_scaling_factor *
thrust::transform_reduce(handle_ptr->get_thrust_policy(),
thrust::counting_iterator<i_t>(0),
thrust::counting_iterator<i_t>(pb.n_variables),
Expand Down