Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voxel Size has been deprecated #74

Open
ramakarl opened this issue Jul 14, 2019 · 0 comments
Open

Voxel Size has been deprecated #74

ramakarl opened this issue Jul 14, 2019 · 0 comments

Comments

@ramakarl
Copy link
Contributor

ramakarl commented Jul 14, 2019

Voxelsize has been deprecated inside GVDB library.

Voxelsize size was originally a scalar on voxels inside GVDB. However, this is obsolete since most applications would like to have arbitrary transforms between world and voxels. The gvdb.SetVoxelSize function has been removed. Support for arbitrary transforms from gvdb grid to world coordinates during rendering is now possible with gvdb.SetTransform, which handles the rendering side of things. Applications are now responsible for maintaining their own voxel-to-world transforms and applying these wherever needed (in custom kernels, during SolidVoxelize, or during rendering with SetTransform).

The g3DPrint example has been updated, and shows how a specific application would maintain its own world transforms. g3DPrint now has m_voxel_size itself since this metric is specific to 3D printing (voxel size is in the sample not inside gvdb library). SolidVoxelize takes in a world transform during polygon-to-voxel conversion, which is maintained by the sample itself. The main_3dprint.cpp provides more detailed comments. This also makes the sample more flexible. The interface now allows for on-the-fly modification of the voxel size.

Currently, only the g3DPrint sample has been updated.
Other samples may still need to be modified.
Applications will now maintain and use their own arbitrary voxel-to-world transforms.

Note: You must rebuild all of gvdb_library in order to adopt these changes

@ramakarl ramakarl pinned this issue Jul 14, 2019
ramakarl added a commit that referenced this issue Jul 14, 2019
Voxel size deprecated.
See pinned issue #74
NBickford-NV added a commit that referenced this issue Jul 10, 2020
… and kernels.

That is, gvdb->vdel[0] is always equal to (1, 1, 1) after the change removing
`voxelsize` (see issue #74).

- The CUDA code's `getNodeAtPoint` now takes four arguments and no longer
returns `vdel` (previously, it always returned `(1, 1, 1)`)

- Removes `pstep` from the `gvdbBrickFunc` signature, as this depends only on `dir`.

- Removes unused functions `rayTricubic`, `rayTrilinear`, and `raySurfaceDepthBrick`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant