Add download directory to the argument parser. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Håkon Hukkelås <hakon.hukkelas@ntnu.no>
alkanen
reviewed
Feb 5, 2019
download_ffhq.py
Outdated
| @@ -384,6 +385,7 @@ def run_cmdline(argv): | |||
| parser.add_argument('--timing_window', help='samples for estimating download eta (default: 50)', type=int, default=50, metavar='LEN') | |||
| parser.add_argument('--chunk_size', help='chunk size for each download thread (default: 128)', type=int, default=128, metavar='KB') | |||
| parser.add_argument('--num_attempts', help='number of download attempts per file (default: 10)', type=int, default=10, metavar='NUM') | |||
| parser.add_argument('--base_directory', help="directory to save the downloaded files (default: current folder)", default="") | |||
There was a problem hiding this comment.
I'd suggest calling the argument "download_directory" instead, because that makes more sense to the user.
There was a problem hiding this comment.
Agreed. Download directory is more intuitive. Updated the PR now.
alkanen
approved these changes
Feb 5, 2019
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
PierreRheault
approved these changes
Apr 1, 2021
|
@PierreRheault would you kindly stop spamming us? |
|
please, is there a data annotation file for the proposed dataset? thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Håkon Hukkelås hakon.hukkelas@ntnu.no
Adds possibility to add --base_directory as an argument to download the dataset outside of the current folder.