Fix data type issue in _compute_doppler_shifts, fixes #426 #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very minor one-line fix for issue #426.
The line in the source code used to say
which causes a TypeError (
TypeError: Input 'e' of 'SelectV2' Op has type float32 that does not match type int32 of argument 't'.
), because0
is an int32, whereasdoppler
is a float32 andtf.where
wants to have same dtypes (at least when using@tf.function
with my TensorFlow installation).I changed it so that the dtype of
0
is chosen based on the dtype ofdoppler
:Not sure if this is the correct way to fix it, but the bug certainly disappears for me.
Checklist