Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test boilerplate #190

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

pierre-wilmot
Copy link

Adding the boilerplate for unit test setup with some minimal grid tests.
Hoping to add test for indexing / hashing in the future.

@pierre-wilmot pierre-wilmot changed the title Test Unit Test boilerplate Nov 4, 2022
@Tom94
Copy link
Collaborator

Tom94 commented Nov 5, 2022

Thank you very much for the PR!

catch.hpp seems to be an external dependency -- could you move it into its own dependencies/catch subfolder in order to make code statistics & licensing work out better? If it comes from a public github repo, it would be even better if it was a submodule like the other dependencies.

Other than that, heads-up that I'll be on vacation for the coming 3 weeks and will get back to the PR afterwards.

@Tom94
Copy link
Collaborator

Tom94 commented Nov 7, 2022

I'm afraid testing within GitHub workflows won't work -- there's no GPU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants