Skip to content

Fix for several problems in dataset #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HejiaZ2023
Copy link

This PR addresses a set of fixes span across the testbenches, reference RTL, and prompts to improve correctness and clarity.

Summary of flaws and proposed fixes:

  1. Prob 099: DUT initiation port mismatch (Changed Testbench)
  2. Prob 118 & 153: Using blocking assignment in sequencial logic (Changed Reference RTL)
  3. Prob 134: Unused input clk port (Changed Prompt + v1 interface + Reference RTL + Testbench)
  4. Prob 135: Not the FSM itself but the next-state logic should be implemented (Changed v2 Prompt)

All feedbacks are welcome! We're more than happy to discuss these changes further to ensure they align with the benchmark motivation and standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant