Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fanbox covers in original size #930

Closed
Psyho7 opened this issue Apr 5, 2021 · 1 comment
Closed

Fanbox covers in original size #930

Psyho7 opened this issue Apr 5, 2021 · 1 comment

Comments

@Psyho7
Copy link

Psyho7 commented Apr 5, 2021

Description

Amm, what about download covers in original size?
I mean, at now, downloaded covers are resized
But you can find url to original size
For example:

Post
https://www.fanbox.cc/@dsmile/posts/2080664
Resized cover
https://pixiv.pximg.net/c/1200x630_90_a2_g5/fanbox/public/images/post/2080664/cover/LuzFC8NEE9HcZQTAsUEH5zvI.jpeg
Original size
https://pixiv.pximg.net/fanbox/public/images/post/2080664/cover/LuzFC8NEE9HcZQTAsUEH5zvI.jpeg

Post
https://www.fanbox.cc/@grande/posts/2071859
Resized cover
https://pixiv.pximg.net/c/1200x630_90_a2_g5/fanbox/public/images/post/2071859/cover/hyHgOfZ1tbMCftdGRukHqnHi.jpeg
Original size
https://pixiv.pximg.net/fanbox/public/images/post/2071859/cover/hyHgOfZ1tbMCftdGRukHqnHi.jpeg

URLs to original size are written without "c/1200x630_90_a2_g5/"

Found it by browser extension Image Max Url
And generated links you can see by this site

Versions

20210326

Nandaka added a commit that referenced this issue Apr 21, 2021
@Nandaka
Copy link
Owner

Nandaka commented Apr 21, 2021

updated to download both resized and full size.
Add regex to replace the c/1200x630_90_a2_g5/ or similar variation, also update the html generator.

Nandaka added a commit that referenced this issue Apr 29, 2021
Nandaka pushed a commit that referenced this issue May 17, 2021
* Update PixivModelFanbox.py

1. removed some codes from implementation full sized cover image enhancement
2. added `descriptionUrlList` for `FanboxPost` to use `PixivHelper.write_url_in_description` to write urls
    i just added urls that could be found in html body which are not images, p blocks, and embeds.

* Update PixivFanboxHandler.py

calls `PixivHelper.write_url_in_description` after processing all images, writing information and htmls

* Update test_PixivModel_fanbox.py
@Nandaka Nandaka closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants