Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aircall): add user operations #77

Merged
merged 4 commits into from
Oct 28, 2024
Merged

feat(aircall): add user operations #77

merged 4 commits into from
Oct 28, 2024

Conversation

khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented Oct 28, 2024

Describe your changes

Add user operations for aircall-basic. Depends on NangoHQ/nango#2907

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

flows.yaml Outdated
endpoint: POST /users
input: CreateUser
delete-user:
description: Delete a user in Aircall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like it but feels more consistent with the rest

Suggested change
description: Delete a user in Aircall
description: Deletes a user in Aircall

});
}

const aInput = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aInput? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, a short for Aircall

khaliqgant added a commit to NangoHQ/nango that referenced this pull request Oct 28, 2024
## Describe your changes
Add in aircall-basic auth type. Required
NangoHQ/integration-templates#77

## Issue ticket number and link
NAN-1963

## Checklist before requesting a review (skip if just adding/editing
APIs & templates)
- [ ] I added tests, otherwise the reason is: 
- [ ] I added observability, otherwise the reason is:
- [ ] I added analytics, otherwise the reason is:
@khaliqgant khaliqgant enabled auto-merge (squash) October 28, 2024 09:58
@khaliqgant khaliqgant merged commit 9ffe0c9 into main Oct 28, 2024
5 checks passed
@khaliqgant khaliqgant deleted the add-aircall branch October 28, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants