Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aircall-basic): [nan-1963] add aircall basic auth provider #2907

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented Oct 28, 2024

Describe your changes

Add in aircall-basic auth type. Required NangoHQ/integration-templates#77

Issue ticket number and link

NAN-1963

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Oct 28, 2024

docs-v2/integrations/all/aircall.mdx Outdated Show resolved Hide resolved
@khaliqgant khaliqgant enabled auto-merge (squash) October 28, 2024 09:46
@khaliqgant khaliqgant merged commit cd16e83 into master Oct 28, 2024
21 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1963-add-in-aircall-api-key-support branch October 28, 2024 09:54
khaliqgant added a commit to NangoHQ/integration-templates that referenced this pull request Oct 28, 2024
## Describe your changes
Add user operations for aircall-basic. Depends on
NangoHQ/nango#2907

## Issue ticket number and link

## Checklist before requesting a review (skip if just adding/editing
APIs & templates)
- [x] I added tests, otherwise the reason is:
- [x] External API requests have `retries`
- [x] Pagination is used where appropriate
- [x] The built in `nango.paginate` call is used instead of a `while
(true)` loop
- [x] Third party requests are NOT parallelized (this can cause issues
with rate limits)
- [ ] If a sync requires metadata the `nango.yaml` has `auto_start:
false`
- [ ] If the sync is a `full` sync then `track_deletes: true` is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants