Addresses #4615, wrap OutputControl:Table:Style and Output:SQLite#171
Merged
Addresses #4615, wrap OutputControl:Table:Style and Output:SQLite#171
Conversation
joseph-robertson
added
NewTest
…on c9c2245c0a) [x86_64-linux], Rubocop 0.81.0)
Merged
19 tasks
jmarrec
approved these changes
Jul 25, 2022
|
|
||
| model = BaselineModel.new | ||
|
|
||
| # make a 1 story, 100m X 50m, 1 zone building |
Comment on lines
+47
to
+61
| ############################################################################### | ||
| # OUTPUTCONTROL:TABLE:STYLE # | ||
| ############################################################################### | ||
|
|
||
| outputcontrol_table_style = model.getOutputControlTableStyle | ||
| outputcontrol_table_style.setColumnSeparator('HTML') | ||
| outputcontrol_table_style.setUnitConversion('InchPound') | ||
|
|
||
| ############################################################################### | ||
| # OUTPUT:SQLITE # | ||
| ############################################################################### | ||
|
|
||
| output_sqlite = model.getOutputSQLite | ||
| output_sqlite.setOptionType('SimpleAndTabular') | ||
| output_sqlite.setUnitConversionforTabularData('None') |
Contributor
There was a problem hiding this comment.
👍 Simple and clear. Did you check the resulting IDF manually to ensure you have the required objects?
Comment on lines
+771
to
+778
| def test_output_objects_2_rb | ||
| result = sim_test('output_objects_2.rb') | ||
| end | ||
|
|
||
| # TODO: To be added in the next official release after: 3.4.0 | ||
| # def test_output_objects_2_osm | ||
| # result = sim_test('output_objects_2.osm') | ||
| # end |
23 tasks
jmarrec
added
AddedOSM
jmarrec
added a commit
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Tests demonstrating NatLabRockies/OpenStudio#4625
Link to relevant GitHub Issue(s) if appropriate:
Link to the Linux.deb installer to use for CI Testing. If not set, it will default to latest official release.
[OpenStudio Installer]: http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/PR-4625/OpenStudio-3.4.1-alpha%2B3c33c84f02-Ubuntu-18.04.deb
This Pull Request is concerning:
NewTest: a new test for a new model API class,Case 1: New test for a new model API class
Please include which class(es) you are adding a test to specifically test for:
Work Checklist
The following has been checked to ensure compliance with the guidelines:
Tests pass either:
with official OpenStudio release (include version):
with current develop (incude SHA): Addresses #4615, wrap OutputControl:Table:Style and Output:SQLite OpenStudio#4625
PendingOSMhas been added to this PRmodel_tests.rbhas a TODO.out.oswhave been committed as they need to be run with an official OpenStudio versionRuby test is stable: when run multiple times on the same machine, it produces the same total site kBTU.
Please paste the heatmap png generated after running the following commands:
model.getThermalZones.sort_by{|z| z.name.to_s}.each do ...so I am sure I put the same ZoneHVAC systems to the same zones regardless of their order)process_results.py(seepython process_results.py --helpfor usage).Object has been added to
autosize_hvac.rbto ensure the autosizedXXX values methods do workReview Checklist
# TODOadded tomodel_tests.rbout.oswhave been committedautosize_hvacas appropriateNewTest,TestFix,NewTestForExisting,OtherNewTest: addPendingOSMorAddedOSM